Actions: Use an instance of the Actions cluster per endpoint instead of having global delegate array. #37799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37799: Size comparison from 73fe30c to bdc4a48 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
…having global delegate array.
jadhavrohit924
force-pushed
the
follow-up/actions
branch
from
bdc4a48 to
880d2f2
Compare
|
PR #37799: Size comparison from 73fe30c to 880d2f2 Increases above 0.2%:
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
jadhavrohit924
force-pushed
the
follow-up/actions
branch
from
de877e5 to
0c82304
Compare
jadhavrohit924
force-pushed
the
follow-up/actions
branch
from
0c82304 to
7cee1f4
Compare
|
PR #37799: Size comparison from 73fe30c to 7cee1f4 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Can you be more specific with what manual tests you ran. My understanding about the testing line is that someone should be able to re-run and validate the same things as you after reading the testing steps |
Updated the testing section. |
andy31415
reviewed
Feb 27, 2025
examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
|
@jadhavrohit924 this does not seem to use Could we somehow assert that the config matches? E.g. the cluster could assert that the actions cluster count is exactly one and maybe there is a way to say or verify that the cluster is mapped to endpoint 1 only. |
andy31415
reviewed
Feb 27, 2025
examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Feb 28, 2025
|
PR #37799: Size comparison from 73fe30c to bde7b06 Increases above 0.2%:
Full report (15 builds for nrfconnect, nxp, telink)
|
andy31415
approved these changes
Mar 3, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…of having global delegate array. (project-chip#37799) * Actions: Use instance of the Actions cluster per endpoint instead of having global delegate array. * Fix unit tests. * Addressed review comments. * Add error logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Testing